Disturbing changes on CodeReview

classic Classic list List threaded Threaded
4 messages Options
Samuel GOUGEON Samuel GOUGEON
Reply | Threaded
Open this post in threaded view
|

Disturbing changes on CodeReview

Hello devs,

I noticed some changes on the CodeReview interface since this week:
  • The download menu of a commit no longer lists parametrized GIT commands to fetchout, cherrypick and push the commit. It is now limited to the Patch-File and Archive rows. This is true whatever is the web browser (observed with FF, Chrome, Safari)

  • When we review files in diff mode, the edit icon switching the diff mode into the edit one at the top of the diff page no longer works: it yields an error page.


Regards
Samuel


_______________________________________________
dev mailing list
[hidden email]
http://lists.scilab.org/mailman/listinfo/dev
Samuel GOUGEON Samuel GOUGEON
Reply | Threaded
Open this post in threaded view
|

Re: Disturbing changes on CodeReview

Le 31/01/2018 à 20:45, Samuel Gougeon a écrit :

  • When we review files in diff mode, the edit icon switching the diff mode into the edit one at the top of the diff page no longer works: it yields an error page.

After some work, this proves to occur only for files whose names start with "%", which is a special character for URLs.
So, it is likely a bug in CodeReview itself, not in the Scilab infrastructure (unless managing "%" in filenames is configurable in CodeReview).

Samuel


_______________________________________________
dev mailing list
[hidden email]
http://lists.scilab.org/mailman/listinfo/dev
Samuel GOUGEON Samuel GOUGEON
Reply | Threaded
Open this post in threaded view
|

Re: Disturbing changes on CodeReview

In reply to this post by Samuel GOUGEON
Le 31/01/2018 à 20:45, Samuel Gougeon a écrit :
Hello devs,

I noticed some changes on the CodeReview interface since this week:
  • The download menu of a commit no longer lists parametrized GIT commands to fetchout, cherrypick and push the commit. It is now limited to the Patch-File and Archive rows. This is true whatever is the web browser (observed with FF, Chrome, Safari)

They are now restored! Thank you.
Samuel


_______________________________________________
dev mailing list
[hidden email]
http://lists.scilab.org/mailman/listinfo/dev
Clément David-3 Clément David-3
Reply | Threaded
Open this post in threaded view
|

Re: Disturbing changes on CodeReview

In reply to this post by Samuel GOUGEON
Hello Samuel,

Great notice ! This issue arise when the codereview server it out of disk space. This is a
notifiable behavior that might be fixed in more recent Gerrit version. You can continue working on
the patchset by using gerrit tools [1] or by crafting the cherry-pick URL by hand.

[1]: https://gerrit-review.googlesource.com/Documentation/cmd-cherry-pick.html

Thanks,

--
Clément

Le jeudi 01 février 2018 à 00:23 +0100, Samuel Gougeon a écrit :

> Le 31/01/2018 à 20:45, Samuel Gougeon a écrit :
> > When we review files in diff mode, the edit icon switching the diff mode into the edit one at
> > the top of the diff page no longer works: it yields an error page.
>  
> After some work, this proves to occur only for files whose names start with "%", which is a
> special character for URLs.
> So, it is likely a bug in CodeReview itself, not in the Scilab infrastructure (unless managing "%"
> in filenames is configurable in CodeReview).
>
> Samuel
>
> _______________________________________________
> dev mailing list
> [hidden email]
> http://lists.scilab.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
[hidden email]
http://lists.scilab.org/mailman/listinfo/dev