Patch/CR policy when new files are added

classic Classic list List threaded Threaded
2 messages Options
mottelet mottelet
Reply | Threaded
Open this post in threaded view
|

Patch/CR policy when new files are added

Hello devs,

I would like to know what is the policy when *new* source files (C,C++
or Java) are added when fixing a bug or adding a feature. A explained in

https://wiki.scilab.org/Scilab%20Module%20Architecture

when new source files are added in a module, Makefile.am has to mention
these files but Makefile.in can only be regenerated by running
autoreconf at the main SCI folder.

So, should I add the resulting Makefile.in in my commit ?

S.


--
Stéphane Mottelet
Ingénieur de recherche
EA 4297 Transformations Intégrées de la Matière Renouvelable
Département Génie des Procédés Industriels
Sorbonne Universités - Université de Technologie de Compiègne
CS 60319, 60203 Compiègne cedex
Tel : +33(0)344234688
http://www.utc.fr/~mottelet
_______________________________________________
dev mailing list
[hidden email]
http://lists.scilab.org/mailman/listinfo/dev
Clément David-3 Clément David-3
Reply | Threaded
Open this post in threaded view
|

Re: Patch/CR policy when new files are added

Hello Stéphane,

Yes you should also commit the Makefile.in ; it should be provided within the source tree to ease
Scilab macros and help pages development as these does not require autotools / vcproj manipulation.

Side note: some projects use a `./bootstrap` or ./autogen.sh` (mainly Gnome ones) to generate them
using the machine local autotools ; we currently stick to Automake guidelines [1].

[1]: https://www.gnu.org/software/automake/manual/automake.html#CVS

Thanks,

--
Clément

Le mardi 03 avril 2018 à 17:09 +0200, Stéphane Mottelet a écrit :

> Hello devs,
>
> I would like to know what is the policy when *new* source files (C,C++
> or Java) are added when fixing a bug or adding a feature. A explained in
>
> https://wiki.scilab.org/Scilab%20Module%20Architecture
>
> when new source files are added in a module, Makefile.am has to mention
> these files but Makefile.in can only be regenerated by running
> autoreconf at the main SCI folder.
>
> So, should I add the resulting Makefile.in in my commit ?
>
> S.
>
>
_______________________________________________
dev mailing list
[hidden email]
http://lists.scilab.org/mailman/listinfo/dev