test_run: <-- REOPENED --> status, vs <-- NOT FIXED -->

classic Classic list List threaded Threaded
2 messages Options
Samuel GOUGEON Samuel GOUGEON
Reply | Threaded
Open this post in threaded view
|

test_run: <-- REOPENED --> status, vs <-- NOT FIXED -->

Hello,

In the code of test_run(), we can observe that the detection of a tag
"<-- REOPENED -->" is implemented.
Yet, such a tag is not documented. In addition, no such tag can be found
in all existing Scilab tests.

I am documenting the versioning of the "<-- NOT FIXED -->" tag. And i am
wondering about this "REOPENED" tag whether it must be documented as
well or not.
Is it an old tag undocumented after deprecation but not removed from
test_run for compatibility reason?
Or is it a dark feature that deserves being actually documented?
Or is it a dark feature that was just a trial and that should be removed
from the code?

Any hint would be helpful about the status of this tag, and its role wrt
other ones, noticeably wrt the "NOT FIXED" tag.

Thanks
Samuel


_______________________________________________
dev mailing list
[hidden email]
http://lists.scilab.org/mailman/listinfo/dev
Clément David-3 Clément David-3
Reply | Threaded
Open this post in threaded view
|

Re: test_run: <-- REOPENED --> status, vs <-- NOT FIXED -->

Hello Samuel,

After a deep dive into Scilab source code, it seems that this REOPENED tag has been introduced (or re-introduced) in 91c98ab05 [1]. It seems used to tag a nonreg test as not fixed when the bug reappears. As none of the tests is using it, this might be removed.

[1]: http://cgit.scilab.org/scilab/commit/?h=6.0&id=91c98ab05

--
Clément

-----Original Message-----
From: dev <[hidden email]> On Behalf Of Samuel Gougeon
Sent: Saturday, February 2, 2019 6:10 PM
To: List dedicated to development questions <[hidden email]>
Subject: [Scilab-Dev] test_run: <-- REOPENED --> status, vs <-- NOT FIXED -->

Hello,

In the code of test_run(), we can observe that the detection of a tag
"<-- REOPENED -->" is implemented.
Yet, such a tag is not documented. In addition, no such tag can be found in all existing Scilab tests.

I am documenting the versioning of the "<-- NOT FIXED -->" tag. And i am wondering about this "REOPENED" tag whether it must be documented as well or not.
Is it an old tag undocumented after deprecation but not removed from test_run for compatibility reason?
Or is it a dark feature that deserves being actually documented?
Or is it a dark feature that was just a trial and that should be removed from the code?

Any hint would be helpful about the status of this tag, and its role wrt other ones, noticeably wrt the "NOT FIXED" tag.

Thanks
Samuel


_______________________________________________
dev mailing list
[hidden email]
http://lists.scilab.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
[hidden email]
http://lists.scilab.org/mailman/listinfo/dev